New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update run conditions for workflows #1494
Conversation
…t.yml only run when it or composite action is updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless I misunderstand the paths
scope, I think we want this to run more often than indicated here.
Right, I now see that I misinterpreted the issue for |
Fair enough, we can add a path exclusion for documentation on the |
Just added a list of files to |
Maybe we need to revisit/talk through all the circumstances we use to run all of these at a future software meeting. |
I think we need to restrict the |
I encountered this in DAGMC recently and didn't port it over to here. May also require an update to the install script. |
Right now, the |
I think you need |
Ah, makes sense. Looks like that syntax is working now! (workflow run) |
Thanks @bquan0 - I think this looks ready to merge - let's try... |
Description
Makes
build_test.yml
run when it or the composite action it uses is updated AND it is a push to thedevelop
branch in the main repo (not forks). Also makesinstall_script.yml
run on everypush
todevelop
and everypull_request
to develop.Motivation and Context
Closes #1292 and #1491, which request the two features I mentioned above.
Behavior
The previous behavior was that
build_test.yml
ran even though there were no changes to itself or the dockerfile that built the image it tested. This is because it usedpaths-ignore:
to filter out files instead of usingpaths:
to specify files to check if they have been changed.The previous behavior of
install_script.yml
was that it only ran when it or the install scriptubuntu.sh
was changed. The current behavior is that it now also runs whenever there is apush
orpull
todevelop
.Other Information
One thing I was wondering was if I should add
docker/*
to thepaths:
ofbuild_test.yml
since it's also indocker_publish.yml
. I didn't add it because I thought it would be redundant sincedocker_publish.yml
hasdocker/*
in itspaths:
anddocker_publish.yml
has a job which runs the same job found inbuild_test.yml
.