Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of relying on
python
being on the path with exactly that name, refer to$PYTHON_EXECUTABLE
inCMakeLists.txt
files.Motivation and Context
PyNE runs python during CMake to generate the
pyne_version.h
file that is included in all C++. This is done with a CMakeexecute_process
where theCOMMAND
has historically been specified aspython
. Not all systems have a python executable with that name; many are now onlypython3
. Our CI always generates apython
executable so we don't see this result.Fixes #1530
Changes
Change the remaining reference to a bare
python
executable to the$PYTHON_EXECUTABLE
discovered in the top level CMake process.