Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better reference to python #1534

Merged
merged 7 commits into from
May 1, 2024
Merged

better reference to python #1534

merged 7 commits into from
May 1, 2024

Conversation

gonuke
Copy link
Contributor

@gonuke gonuke commented Apr 29, 2024

Description

Instead of relying on python being on the path with exactly that name, refer to $PYTHON_EXECUTABLE in CMakeLists.txt files.

Motivation and Context

PyNE runs python during CMake to generate the pyne_version.h file that is included in all C++. This is done with a CMake execute_process where the COMMAND has historically been specified as python. Not all systems have a python executable with that name; many are now only python3. Our CI always generates a python executable so we don't see this result.

Fixes #1530

Changes

Change the remaining reference to a bare python executable to the $PYTHON_EXECUTABLE discovered in the top level CMake process.

@gonuke
Copy link
Contributor Author

gonuke commented Apr 29, 2024

I expanded this PR to fix some other CI issues

@gonuke gonuke requested a review from bquan0 April 29, 2024 17:32
Copy link
Contributor

@bquan0 bquan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @gonuke. I like all the changes to the CI files to match the new build process.

@gonuke
Copy link
Contributor Author

gonuke commented Apr 30, 2024

Go ahead and merge @bquan0 - when you think it's ready. The docker_publish workflow won't pass but I decided to skip reissuing this PR from a local branch. Let me know if you want me to do that.

@bquan0 bquan0 merged commit 94655cf into pyne:develop May 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Error: 'pyne_version.h' file not found
2 participants