Fixing energy ordering #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @elliottbiondo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PARTISN, energy-dependent quantities are ordered from high-energy to low-energy. I could not find explicit documentation of this, but I was about to confirm this by experiment. I ran transport problems with source intensity only in the last energy group (i.e. the lowest energy group in PARTISN), and confirmed that fluxes in all other groups were zero. I also did the reverse --- only flux in the first group --- and confirmed that particles were indeed downscattering in the other groups.
In PyNE we have been using the opposite convention --- low-energy to high-energy --- consistent with MCNP. The PR fixes PARTISN functionality to be consistent with the rest of PyNE. For unit tests, I was able to simply reverse the order of input spectra, minimizing what needed to be changed.