Data source fix #841
Merged
Data source fix #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _compute_xslib(nuc, key, t9[nlb[1]], xscache) | ||
| if nuc in FISSION_PRODUCT_NUCS: | ||
| _compute_xslib(nuc, key, t9[nlb[2]], xscache) | ||
| try: |
There was a problem hiding this comment.
Try blocks should be a couple of lines at most, and ideally should only be 1 line This is too all-encompassing. I think you should have three try-except blocks, one in each of the conditionals.
|
Thanks for putting this in @FlanFlanagan! |
|
Also, could you please add a test to ensure that the new KeyError issue happens? This should be pretty easy to do since you can create a cache with no data sources and then assert that it raises a KeyError whenever you try to get anything out of it. |
|
@scopatz ping. I fixed the test, I think. |
|
Thanks @FlanFlanagan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A key error catch for missing cross sections within a cross section cache when building TAPE9.INP files. Probably needs some refinement.