pcap_ex.c: fix immediate mode for linux #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The code that sets immediate mode should also consider that apparently on Linux BIOCIMMEDIATE is not (or could be not in certain cases) included. Currently this is not done, and a MacOS specific ioctl is invoked instead. Which should explain the "couldn't enable immediate mode error" that I reported in TheTorProject/ooni-probe#472 and possibly also #12.
The shell session below, taken from a Vagrant precise32 test box shows that BIOCIMMEDIATE is not available in
/usr/include
. Also, with the patched pypcap, ooni-probe's tests using pypcap work on such box, while with 1.1.4 they fail (and note that they used to work with 1.1.3.).(I don't exactly know what immediate mode is. This diff just ensures that what was happening with 1.1.3 continues to happen on Linux. If there are better ways to deal with this in Linux, let me know.)
Thanks!