FIX Avoid compressing files twice when deploying #1767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1764
With the previous version of the
find -exec ...
command what seems to be happening is that as files are compressed and renamed,find
considers these to be new files and re-applies exec again. This would have been avoided if we kept the .gz extension (gzip refuses to compress .gz files) but since we need to preserve the file name, there is no way to detect it. No idea why it only happens with some files.I can't find much existing discussions about this behavior but it's what I observe empirically. Moving to a
find -print0 | xargs -0 -n1
should fix it.Skipping CI, since this will only run for deployment (and I tested it in the Circle CI job)