Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Avoid compressing files twice when deploying #1767

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

rth
Copy link
Member

@rth rth commented Aug 1, 2021

Closes #1764

With the previous version of the find -exec ... command what seems to be happening is that as files are compressed and renamed, find considers these to be new files and re-applies exec again. This would have been avoided if we kept the .gz extension (gzip refuses to compress .gz files) but since we need to preserve the file name, there is no way to detect it. No idea why it only happens with some files.

I can't find much existing discussions about this behavior but it's what I observe empirically. Moving to a find -print0 | xargs -0 -n1 should fix it.

Skipping CI, since this will only run for deployment (and I tested it in the Circle CI job)

@rth rth merged commit e938d58 into pyodide:main Aug 1, 2021
@rth rth deleted the fix-gzip-deployment branch August 1, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gzip encoding issue with jedi in v0.18.0a1
1 participant