Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminal Ctrl+C handling #1790

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Fix terminal Ctrl+C handling #1790

merged 5 commits into from
Aug 13, 2021

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Aug 12, 2021

This resolves #1787 and should bring repl behavior a bit closer to what happens in native console. I also made the text a bit whiter because I think the text contrast is slightly low.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@rth
Copy link
Member

rth commented Aug 13, 2021

Could you add a changelog entry (under a similar subsection to the one used in 0.18 release)? Thanks!

@hoodmane hoodmane merged commit cacfdde into pyodide:main Aug 13, 2021
@hoodmane hoodmane deleted the console-ctrl-c branch August 13, 2021 18:13
rth pushed a commit to rth/pyodide that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+C support in REPL
2 participants