Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Don't destroy attribute proxies if root proxy is leaked and GC'd #1870

Merged
merged 2 commits into from
Oct 7, 2021
Merged

FIX Don't destroy attribute proxies if root proxy is leaked and GC'd #1870

merged 2 commits into from
Oct 7, 2021

Conversation

hoodmane
Copy link
Member

This resolves #1855. I think it's an improvement?

@hoodmane hoodmane changed the title Don't destroy attribute proxies if root proxy is leaked and GC'd FIX Don't destroy attribute proxies if root proxy is leaked and GC'd Oct 7, 2021
@hoodmane hoodmane merged commit edc0f87 into pyodide:main Oct 7, 2021
@hoodmane hoodmane deleted the gcd-attributes branch October 7, 2021 17:41
@hoodmane hoodmane mentioned this pull request Oct 7, 2021
Closed
@rth rth mentioned this pull request Oct 12, 2021
Closed
@rth
Copy link
Member

rth commented Oct 12, 2021

There is a consistent failure in test_pyproxy_gc_destroy in Node.js after this PR was merged #1884

@hoodmane hoodmane mentioned this pull request Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy gets wrongly destroyed.
2 participants
@hoodmane @rth