Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH improvements to pyodide-build #2069

Merged
merged 43 commits into from
Dec 31, 2021
Merged

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Dec 28, 2021

Description

More improvements to pyodide-build. This includes:

  1. some tuneups to pywasmcross extracted from Update to Scipy 1.7.3 #2065
  2. a --continue flag that allows skipping parts of the package build in buildpkg for debugging the build
  3. better handling of skipping already built packages in buildall -- in particular, it will now rebuild a package if a package that it depends on is being rebuilt, and the messages printed are a bit clearer.
  4. a --force flag to force a rebuild

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Update documentation

@hoodmane hoodmane changed the title MAINT buildall handle already built packages in a more understandable… ENH improvements to pyodide-build Dec 28, 2021
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, otherwise LGTM. Thanks!

pyodide-build/pyodide_build/buildall.py Show resolved Hide resolved
pyodide-build/pyodide_build/buildall.py Outdated Show resolved Hide resolved
pyodide-build/pyodide_build/buildall.py Outdated Show resolved Hide resolved
pyodide-build/pyodide_build/buildall.py Outdated Show resolved Hide resolved
pyodide-build/pyodide_build/buildpkg.py Outdated Show resolved Hide resolved
pyodide-build/pyodide_build/buildpkg.py Show resolved Hide resolved
pyodide-build/pyodide_build/buildpkg.py Show resolved Hide resolved
pyodide-build/pyodide_build/buildpkg.py Outdated Show resolved Hide resolved
@hoodmane hoodmane merged commit f44f7b3 into pyodide:main Dec 31, 2021
@hoodmane hoodmane deleted the pyodide-build-flags branch December 31, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants