Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated pyb2d version #2117

Merged
merged 3 commits into from
Jan 24, 2022
Merged

updated pyb2d version #2117

merged 3 commits into from
Jan 24, 2022

Conversation

DerThorsten
Copy link
Contributor

Description

Updated pyb2d from 0.4 to 0.7.2

Checklists

  • Add a CHANGELOG entry
  • Add / update tests (tests are still fine, no need for update)
  • Add new / update outdated documentation (nothing outdated, no need for changes)

@DerThorsten DerThorsten marked this pull request as draft January 20, 2022 10:30
@DerThorsten DerThorsten marked this pull request as ready for review January 20, 2022 11:22
@DerThorsten DerThorsten marked this pull request as draft January 20, 2022 11:26
@DerThorsten DerThorsten changed the title updated pyodide version updated pyb2d version Jan 20, 2022
@hoodmane
Copy link
Member

Pydantic seems to have a missing dependency on typing_extensions.

@DerThorsten DerThorsten marked this pull request as ready for review January 24, 2022 10:48
@DerThorsten DerThorsten marked this pull request as draft January 24, 2022 10:53
@DerThorsten DerThorsten marked this pull request as ready for review January 24, 2022 10:56
@DerThorsten
Copy link
Contributor Author

@hoodmane this seems to be good to go, the errors in the ci (https://app.circleci.com/pipelines/github/pyodide/pyodide/3386/workflows/03d5a682-8a81-4824-9894-0381902cc68e/jobs/36251) seem unrelated to my changes.
Nevertheless I triggered an empty commit to rerun the CI

@DerThorsten
Copy link
Contributor Author

and again....

@DerThorsten
Copy link
Contributor Author

jay, green light =)

rth
rth approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DerThorsten !

@rth rth merged commit e6ef8d6 into pyodide:main Jan 24, 2022
@DerThorsten
Copy link
Contributor Author

looking forward to a new release!
Just FYI with pyb2d one can do such things in the browser with jupyterlite

@rth
Copy link
Member

rth commented Jan 24, 2022

Just FYI with pyb2d one can do such things in the browser with jupyterlite

Very nice indeed! The readme and the documentation could use a more detailed description as after skimming through it I'm still not sure how it does what it does :) The sphinx gallery examples are pure JS, right? It doesn't look like you are loading pyodide there unless I missed it?

hoodmane pushed a commit that referenced this pull request Jan 26, 2022
@DerThorsten @hoodmane
PKG updated pyb2d version (#2117)
9f95a62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DerThorsten @hoodmane @rth