Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in scipy f2py wrapper for nrm2 #2728

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Jun 16, 2022

This is a one character change: nm2 ==> n2.

@hoodmane
Copy link
Member Author

The patches to fblas from make-int-return-values seem to have introduced some problems. I'm not sure what happens if we revert the changes to fblas_l1, maybe that would be better.

@hoodmane
Copy link
Member Author

hoodmane commented Jun 16, 2022

This brings scipy.sparse fairly close to working:

> await pyodide.loadPackage(["scipy-tests", "pytest"]);
> let pytest = pyodide.pyimport("pytest");
> pytest.main(pyodide.toPy(["--pyargs", "scipy.sparse", "--continue-on-collection-errors",'-vv', '-k', 'not test_cornercase and not iterative and not test_exception']))
= 3 failed, 6417 passed, 1618 skipped, 62 deselected, 45 xfailed in 258.04s (0:04:18) =

The three failures are due to threading. test_cornercase and iterative both cause memory corruption =(

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants