-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to create Pyodide virtual environment #2976
Conversation
Very cool! We should probably pre-install micropip here by default, same way as venv pre-installs pip. It's very impressive that |
487a4c6
to
a8336cd
Compare
It seems to me that the standard library
https://virtualenv.pypa.io/en/latest/ I think for this reason it is unusable for us. I have just added a script |
You should add it to pyproject.toml at Line 25 in 555f782
|
(One of the runs is not strictly checked for imports, and it seems this file is being checked in both MyPy runs. You might want to exclude it from one of them.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to this! A couple of comments otherwise LGTM.
] | ||
|
||
for pip in other_pips: | ||
pip.unlink() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe missing_ok=True?
dedent( | ||
f""" | ||
#!/bin/sh | ||
{environment} exec {sys.executable} -m pyodide_build.out_of_tree "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will have to change once we migrate to the pyodide-cli but OK to do it in a separate MR.
@henryiii I figured out the issue: if |
Then you can put Not following closely, but build supports both |
@rth @ryanking13 getting the error:
|
#3084 will fix it. |
Thanks a lot! |
This is work in progress. To use:
pip install pyodide-build
pyodide venv .venv-pyodide
source .venv-pyodide/bin/active
pip install .[tests]
orpip install -r test_requirements.txt
etcpython -m pytest