-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simplejson #3801
Add simplejson #3801
Conversation
for more information, see https://pre-commit.ci
simplejson is pure Python right? So you should be able to install it with micropip.
I don't quite understand what you mean by this, but maybe I am missing something. In principle |
No, it has some (optional) C extensions for speedups, and doesn't ship a pure Python wheel, so it can't be installed with If we include it in Pyodide, we enable installing some libraries which have |
OK I was not aware of this. For some reason |
Ah okay, not sure what error I got that led me to believe there wasn't a pure Python wheel. Sorry about that. It still might be worthwhile to include this package with the speedups in Pyodide though. The test assures the speedups are also there, so we don't install the pure Python wheel with extra steps. |
I found out what happened, the project that I micropip installed depended on an older version of I'll make a PR to get that package up-to-date as well. |
Well it doesn't hurt to include a faster compiled version. |
Alright! The test that imports Let's hope it passes all CI checks this time. |
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Listen to pre commit bot [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
4948acd
to
eeb6fd3
Compare
Conveniently it doesn't depend on numpy so it isn't affected by #3816. |
Thanks @bartbroere! |
Add the
simplejson
package, so other packages can be more easily micropip installed if they happen to depend on this.