Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sourmash to 4.8.3 #4075

Merged
merged 1 commit into from Aug 23, 2023
Merged

Conversation

luizirber
Copy link
Contributor

@luizirber luizirber commented Aug 17, 2023

Description

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @luizirber!

@@ -17,8 +17,8 @@ requirements:
executable:
- rustup
source:
url: https://pypi.io/packages/source/s/sourmash/sourmash-4.8.0.tar.gz
sha256: 778d5d182f9e625ae560a5b3a2fdf6bd4fd3b876c84593da8c8c07d11ce2c697
url: https://pypi.io/packages/source/s/sourmash/sourmash-4.8.3.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://pypi.io/packages/source/s/sourmash/sourmash-4.8.3.tar.gz
url: https://files.pythonhosted.org/packages/82/dc/bfc4ce1bd64d58495b6ccd5b10cbad79b568e327b347539d465ba0bcc43a/sourmash-4.8.3.tar.gz

Maybe let's use a direct URL. Using pypi.io redirects three times.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, that's a lot of redirects! Fixed.

@ryanking13 ryanking13 added this to the 0.24.0 milestone Aug 21, 2023
@ryanking13 ryanking13 merged commit 070bb2e into pyodide:main Aug 23, 2023
21 of 22 checks passed
@luizirber luizirber deleted the lirber/sourmash_483 branch August 23, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants