Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] "Union" to "|" #613

Merged
merged 8 commits into from
Feb 8, 2023
Merged

[RTR] "Union" to "|" #613

merged 8 commits into from
Feb 8, 2023

Conversation

20chupin
Copy link
Contributor

@20chupin 20chupin commented Feb 3, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

Related to #585


This change is Reviewable

20chupin and others added 6 commits February 2, 2023 17:02
Done for all the files until the "optimization" folder
Change done in all the bioptim folder
adapt "np.array" to "np.ndarray"
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 81.51% // Head: 81.49% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (258a307) compared to base (cc31341).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   81.51%   81.49%   -0.03%     
==========================================
  Files         106      106              
  Lines       11789    11776      -13     
==========================================
- Hits         9610     9597      -13     
  Misses       2179     2179              
Impacted Files Coverage Δ
bioptim/dynamics/fatigue/xia_fatigue.py 96.29% <ø> (ø)
...les/custom_model/custom_package/custom_dynamics.py 100.00% <ø> (ø)
...ioptim/examples/getting_started/custom_dynamics.py 88.37% <ø> (-0.27%) ⬇️
...xamples/getting_started/example_external_forces.py 87.87% <ø> (ø)
...tim/examples/getting_started/example_multistart.py 24.24% <ø> (ø)
...les/torque_driven_ocp/multi_model_by_constraint.py 83.60% <ø> (ø)
...amples/torque_driven_ocp/multi_model_by_mapping.py 83.33% <ø> (ø)
...ase_transition_uneven_variable_number_by_bounds.py 92.00% <ø> (ø)
...se_transition_uneven_variable_number_by_mapping.py 91.66% <ø> (ø)
bioptim/interfaces/biomodel.py 100.00% <ø> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@20chupin 20chupin changed the title "Union" to "|" [RTR] "Union" to "|" Feb 7, 2023
@20chupin
Copy link
Contributor Author

20chupin commented Feb 7, 2023

@pariterre

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 58 of 58 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @20chupin)


bioptim/dynamics/configure_problem.py line 1335 at r1 (raw file):

        Parameters
        ----------
        dynamics_type: Callable| DynamicsFcn

There is a space missing here

@pariterre
Copy link
Member

Almost nothing to say ;)

@20chupin
Copy link
Contributor Author

20chupin commented Feb 8, 2023

I don't know how to resolve the discussion but I have corrected this missing space ! @pariterre

@pariterre
Copy link
Member

@20chupin
You must type "Done" in "Reviewable" (See the button at the top of the discussion). Even though it is not useful, I'll let you write the "Done" so you see where it is!

Copy link
Contributor Author

@20chupin 20chupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 57 of 58 files reviewed, 1 unresolved discussion (waiting on @pariterre)


bioptim/dynamics/configure_problem.py line 1335 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

There is a space missing here

Done.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @20chupin)

@pariterre pariterre merged commit d0f968b into pyomeca:master Feb 8, 2023
@20chupin 20chupin deleted the Union branch May 8, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants