-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTR] "Union" to "|" #613
[RTR] "Union" to "|" #613
Conversation
Done for all the files until the "optimization" folder
Change done in all the bioptim folder
adapt "np.array" to "np.ndarray"
Codecov ReportBase: 81.51% // Head: 81.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
==========================================
- Coverage 81.51% 81.49% -0.03%
==========================================
Files 106 106
Lines 11789 11776 -13
==========================================
- Hits 9610 9597 -13
Misses 2179 2179
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 58 of 58 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @20chupin)
bioptim/dynamics/configure_problem.py
line 1335 at r1 (raw file):
Parameters ---------- dynamics_type: Callable| DynamicsFcn
There is a space missing here
Almost nothing to say ;) |
I don't know how to resolve the discussion but I have corrected this missing space ! @pariterre |
@20chupin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 57 of 58 files reviewed, 1 unresolved discussion (waiting on @pariterre)
bioptim/dynamics/configure_problem.py
line 1335 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
There is a space missing here
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @20chupin)
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
Related to #585
This change is