Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT orthonormal #235

Merged
merged 18 commits into from
Sep 29, 2021
Merged

RT orthonormal #235

merged 18 commits into from
Sep 29, 2021

Conversation

EveCharbie
Copy link
Contributor

I think the link Micakel sent is the right way to do it :) So we need to include https://github.com/martinbis11/polar-decomposition-3x3.

I think the link Micakel sent is the right way to do it :) So we need to include https://github.com/martinbis11/polar-decomposition-3x3.
@mickaelbegon
Copy link

@EveCharbie EveCharbie changed the title Initial commit RT orthonormal Sep 23, 2021
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good

src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Show resolved Hide resolved
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments

src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
src/Utils/Rotation.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #235 (23e114b) into master (562f298) will decrease coverage by 0.00%.
The diff coverage is 82.05%.

❗ Current head 23e114b differs from pull request most recent head a9fd7d5. Consider uploading reports for the commit a9fd7d5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   77.21%   77.20%   -0.01%     
==========================================
  Files          96       96              
  Lines       10378    10414      +36     
==========================================
+ Hits         8013     8040      +27     
- Misses       2365     2374       +9     
Impacted Files Coverage Δ
include/Utils/Matrix3d.h 40.00% <ø> (ø)
src/Utils/Rotation.cpp 48.12% <22.22%> (-2.15%) ⬇️
src/Utils/Matrix3d.cpp 100.00% <100.00%> (ø)
test/test_utils.cpp 100.00% <100.00%> (ø)
src/Utils/String.cpp 83.78% <0.00%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562f298...a9fd7d5. Read the comment docs.

@pariterre
Copy link
Member

pariterre commented Sep 29, 2021

The windows failing bug is fixed in #236
If you are happy with these changes @EveCharbie I can already merge!

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants