-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT orthonormal #235
RT orthonormal #235
Conversation
I think the link Micakel sent is the right way to do it :) So we need to include https://github.com/martinbis11/polar-decomposition-3x3.
Have a look here using Eigen3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, so good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more comments
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 77.21% 77.20% -0.01%
==========================================
Files 96 96
Lines 10378 10414 +36
==========================================
+ Hits 8013 8040 +27
- Misses 2365 2374 +9
Continue to review full report at Codecov.
|
The windows failing bug is fixed in #236 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
I think the link Micakel sent is the right way to do it :) So we need to include https://github.com/martinbis11/polar-decomposition-3x3.