Added mesh properties in ModelWriter (meshcolor, meshscale, meshrt) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 78.35% 78.21% -0.14%
==========================================
Files 101 101
Lines 11455 11479 +24
==========================================
+ Hits 8975 8978 +3
- Misses 2480 2501 +21
Continue to review full report at Codecov.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pertains to #253. I've added the
meshcolor,meshscaleandmeshrtproperties to the ModelWriter class. Compiled with Debug, Eigen3, Casadi and ran tests, all seems good. Ran the script here and the output .bioMod is correct now.I made two member variables in
Mesh(m_scale,m_rotation), that keep track of the applied rotation and scale since that wasn't there before. Let me know if you'd like me to change anything!