Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Type 1 and 3 #140

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Fixed Type 1 and 3 #140

merged 6 commits into from
Aug 17, 2020

Conversation

pariterre
Copy link
Member

No description provided.

@pariterre
Copy link
Member Author

@nikorose87
Just so you know, I added support for Type 1 and 3! However, I've noticed differences with BTK which I think is errors in BTK, or at least weird assumption. I wanted to validated with OpenSim what they want regarding this, do they want to have similar behavior, or that I use my previous assumption.
As soon as I sorted this out with them, I push the new Ezc3d version!

@nikorose87
Copy link

Thanks @pariterre for your effort. In fact, what I finally expect is to run from Opensim the conversion of the c3d files into Opensim compatible formats (trc and mot). So It would be a nice idea to validate with them ar first.

Regards.

@pariterre pariterre merged commit 70dd857 into pyomeca:type1_3 Aug 17, 2020
@nikorose87
Copy link

So far, the new commit is working. Can I build this branch with Opensim, or should I wait until merging with the master?

@pariterre
Copy link
Member Author

Hello!
As far as I am concerned, this branch is stable, I just wait to add tests before merging too stable!
However, even though I think my implementation is right, I may have to comply to Opensim request if they want to keep the big from BTK (for the type 1 force plays, it doesn't give the values in the correct reference frame)...

So, from ezc3d point of view, I will keep it as is, but I may have to reintroduce the BTK behavior in Opensim.

Still, if you want too use it right now, you can build this branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants