Removed the double free in ezc3d class #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #203 +/- ##
==========================================
- Coverage 84.57% 84.55% -0.02%
==========================================
Files 43 44 +1
Lines 5522 5515 -7
==========================================
- Hits 4670 4663 -7
Misses 852 852
Continue to review full report at Codecov.
|
Kilidsch
reviewed
Jun 1, 2021
Comment on lines
+201
to
+204
| std::vector<char>(c_float); ///< Char to be used by the read function with the specific size of a float preventing to allocate it at each calls | ||
| std::vector<char>(c_float_tp); ///< Char to be used by the read function with the specific size of a float preventing to allocate it at each calls (allow for copy of c_float) | ||
| std::vector<char>(c_int); ///< Char to be used by the read function with the specific size of a int preventing to allocate it at each calls | ||
| std::vector<char>(c_int_tp); ///< Char to be used by the read function with the specific size of a int preventing to allocate it at each calls (allow for copy of c_int) |
There was a problem hiding this comment.
The parantheses are not needed. Actually, they throw warnings on my compiler with my flags:
include/ezc3d.h:201:22: warning: unnecessary parentheses in declaration of 'c_float' [-Wparentheses]
std::vector<char>(c_float); ///< Char to be used by the read function with the specific size of a float preventing to allocate it at each calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.