Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2019.6 #74

Merged
merged 152 commits into from
Aug 24, 2019
Merged

Release 2019.6 #74

merged 152 commits into from
Aug 24, 2019

Conversation

pariterre
Copy link
Member

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can also fill these out after creating the PR. This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

pariterre and others added 26 commits July 11, 2019 15:37
allowed for parsing using names
Shape a return for some functions
Updated RotoTrans for being more compliant with 3d structure that has been developed previously
for frame in data:
  print(frame)
is now fully functional for all FrameDependent
Fixed the iterator problem
plot was broken after the implementation of a proper __next__. It is now fixed
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0b3513a). Click here to learn what that means.
The diff coverage is 67.48%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #74   +/-   ##
========================================
  Coverage          ?   49.8%           
========================================
  Files             ?       6           
  Lines             ?     785           
  Branches          ?       0           
========================================
  Hits              ?     391           
  Misses            ?     394           
  Partials          ?       0
Impacted Files Coverage Δ
pyomeca/__init__.py 100% <100%> (ø)
pyomeca/generalized_coordinates.py 38.46% <100%> (ø)
pyomeca/analogs.py 29.32% <35.29%> (ø)
pyomeca/markers.py 61.81% <42.85%> (ø)
pyomeca/frame_dependent.py 48.38% <59.2%> (ø)
pyomeca/rototrans.py 61.83% <85.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3513a...f5892bc. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0b3513a). Click here to learn what that means.
The diff coverage is 67.48%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #74   +/-   ##
========================================
  Coverage          ?   49.8%           
========================================
  Files             ?       6           
  Lines             ?     785           
  Branches          ?       0           
========================================
  Hits              ?     391           
  Misses            ?     394           
  Partials          ?       0
Impacted Files Coverage Δ
pyomeca/__init__.py 100% <100%> (ø)
pyomeca/generalized_coordinates.py 38.46% <100%> (ø)
pyomeca/analogs.py 29.32% <35.29%> (ø)
pyomeca/markers.py 61.81% <42.85%> (ø)
pyomeca/frame_dependent.py 48.38% <59.2%> (ø)
pyomeca/rototrans.py 61.83% <85.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3513a...f5892bc. Read the comment docs.

@romainmartinez romainmartinez merged commit 85ff637 into master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants