Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov badge url #68

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Fix codecov badge url #68

merged 2 commits into from
Jul 26, 2019

Conversation

romainmartinez
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #68 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #68   +/-   ##
=======================================
  Coverage   50.58%   50.58%           
=======================================
  Files           6        6           
  Lines         775      775           
=======================================
  Hits          392      392           
  Misses        383      383

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc3ee3...f1f16bd. Read the comment docs.

@pariterre
Copy link
Member

Is that expected that Codacy complains? If so, I will merge the PR

@romainmartinez
Copy link
Member Author

Yep. I'll fix the codacy complaints later (#70)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pariterre pariterre merged commit cd10b65 into dev Jul 26, 2019
@pariterre pariterre deleted the fix-codecov-badge branch July 26, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants