Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make examples great again #77

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Make examples great again #77

merged 3 commits into from
Sep 4, 2019

Conversation

pariterre
Copy link
Member

Proposed changes

Examples didn't follow the update in API, it now does

This is related to #75

Types of changes

What types of changes does your code introduce?

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #77 into dev will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev      #77      +/-   ##
=========================================
- Coverage   49.8%   49.68%   -0.13%     
=========================================
  Files          6        6              
  Lines        785      787       +2     
=========================================
  Hits         391      391              
- Misses       394      396       +2
Impacted Files Coverage Δ
pyomeca/frame_dependent.py 48.12% <0%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5892bc...3c2547f. Read the comment docs.

@romainmartinez
Copy link
Member

Great thanks!

@romainmartinez romainmartinez merged commit a89ef24 into pyomeca:dev Sep 4, 2019
@pariterre pariterre deleted the ExampleSavior branch September 12, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants