Remove non all PEP503 conformant paths #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PEP503 says we only need to store the normalized path / name for packages - Moderns pip supports this - Lets remove the legacy normalization and 1.5 non normalized directories for simple html - Also make package.py full mypy / PEP484 compliant Have made a note in documentation about this. Tests: - Update tests to only expect normalized directories Fixes #138
cooperlees
force-pushed
the
remove_pip_8x_hacks
branch
from
3a3d8e2
to
ac833ae
Compare
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 82.08% 81.77% -0.31%
==========================================
Files 10 10
Lines 1133 1114 -19
Branches 173 167 -6
==========================================
- Hits 930 911 -19
- Misses 161 162 +1
+ Partials 42 41 -1
Continue to review full report at Codecov.
|
techalchemy
approved these changes
Mar 16, 2020
| @@ -64,28 +66,18 @@ def normalized_simple_directory(self) -> Path: | |||
| ) | |||
| return self.mirror.webdir / "simple" / self.normalized_name | |||
There was a problem hiding this comment.
so the difference here is the legacy format used a parent directory with the first letter as the top level directory name? I just want to be sure I understand correctly what is going away
There was a problem hiding this comment.
As we discussed on IRC - Just the PEP's normalization function rather than some arbitrary one from back in the day in distutils.
This will also cause less to be on disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have made a note in documentation about this.
Tests:
Fixes #138