Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make packages only store PEP 503 Simple API Directory #465

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Make packages only store PEP 503 Simple API Directory #465

merged 2 commits into from
Mar 23, 2020

Conversation

cooperlees
Copy link
Contributor

  • No longer need to store the Simple API other than PEP normalized name
  • Add a cleanup function to remove uneeded directories from existing mirrors

Tests:

  • Add a unit test for cleanup
  • Ensure current unittests pass
  • See CI run pass

@cooperlees
Make packages only store PEP 503 Simple API Directory
ee37eeb 
- No longer need to store the Simple API other than PEP normalized name
- Add a cleanup function to remove uneeded directories from existing mirrors

Tests:
- Add a unit test for cleanup
- Ensure current unittests pass
- See CI run pass
@cooperlees cooperlees added enhancement New feature or request 4.0 labels Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020 •
edited
Loading

Codecov Report

Merging #465 into master will decrease coverage by 0.14%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   81.77%   81.63%   -0.15%     
==========================================
  Files          10       10              
  Lines        1114     1138      +24     
  Branches      167      171       +4     
==========================================
+ Hits          911      929      +18     
- Misses        162      167       +5     
- Partials       41       42       +1
Impacted Files Coverage Δ
src/bandersnatch/__init__.py 100% <ø> (ø) ⬆️
src/bandersnatch/verify.py 51.47% <100%> (ø) ⬆️
src/bandersnatch/mirror.py 86.64% <57.14%> (-0.77%) ⬇️
src/bandersnatch/package.py 80% <86.04%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e57700...a7010c7. Read the comment docs.

@cooperlees cooperlees mentioned this pull request Mar 23, 2020
Closed
techalchemy
techalchemy approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@techalchemy techalchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me, i dont see any drastic changes tbh so it shouldn't be too bad

@cooperlees cooperlees merged commit a1911a5 into master Mar 23, 2020
@cooperlees cooperlees deleted the verify_delete_json branch March 23, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techalchemy techalchemy techalchemy approved these changes

@dstufft dstufft Awaiting requested review from dstufft

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cooperlees @techalchemy