Introduce a centralized GHA check/gate job #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
requested review from
FFY00,
gaborbernat,
layday and
henryiii
as code owners
webknjaz
force-pushed
the
maintenance/gha-check
branch
from
29514c8
to
90070b1
Compare
henryiii
reviewed
Dec 1, 2022
layday
reviewed
Dec 1, 2022
webknjaz
force-pushed
the
maintenance/gha-check
branch
from
90070b1
to
8c72726
Compare
This patch is intended to lower the maintenance burden of having to manually go through each matrix subjob name in the branch protection repository settings. It allows to only include the `check` job in the branch protection and it will robustly determine if the dependencies have succeeded or not. It is currently mostly serves the Python ecosystem in projects like aiohttp, attrs, cryptography, pydantic, open edX, pip etc. But I've also seen other communities picking it up lately, like the AWS Rust SDK and even the engine powering https://dev.to, to my surprise. Strictly speaking, it is agnostic. Ref: https://github.com/marketplace/actions/alls-green#why
webknjaz
force-pushed
the
maintenance/gha-check
branch
from
8c72726
to
12f0c55
Compare
henryiii
approved these changes
Dec 2, 2022
|
@layday anything else needed for the merge? Note that there's an action item to swap out the branch protection settings that is post-merge. Don't do this before merging, since it'll block other PRs until something is able to report a check with this name. |
|
@layday FWIW merging this is harmless, it's the branch protection bit that requires extra privileges. But merging will just add an extra check reported but not used, which is fine. I'd even recommend doing so earlier than later because all the PRs with the old workflow definitions will have to be restarted to report this check. The earlier this happens, the less friction switching the branch protection setting will cause. |
|
cc @henryiii |
|
Thanks! |
This was referenced Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is intended to lower the maintenance burden of having to manually go through each matrix subjob name in the branch protection repository settings. It allows to only include the
checkjob in the branch protection and it will robustly determine if the dependencies have succeeded or not.It is currently mostly serves the Python ecosystem in projects like aiohttp, attrs, cryptography, pydantic, open edX, pip etc. But I've also seen other communities picking it up lately, like the AWS Rust SDK and even the engine powering https://dev.to, to my surprise. Strictly speaking, it is agnostic.
Ref: https://github.com/marketplace/actions/alls-green#why