Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Remove nose from testing & docs #499

Closed
henryiii opened this issue Dec 23, 2020 · 2 comments · Fixed by #1898
Closed

[idea] Remove nose from testing & docs #499

henryiii opened this issue Dec 23, 2020 · 2 comments · Fixed by #1898

Comments

@henryiii
Copy link
Contributor

henryiii commented Dec 23, 2020

I've noticed the Windows Travis build failed because it couldn't download nose - can we remove nose from our tests and docs? Nose has been abandoned since 2015 in favor of pytest, which can run nose tests (and unittest and its own pytest format too). All major packages (including NumPy) transitioned over to pytest from nose. Showing abandonware in examples is not a great idea, IMO. :)

git grep nose

.gitignore:nosetests.xml
docs/options.md:# run the project tests against the installed wheel using `nose`
docs/options.md:CIBW_TEST_COMMAND: nosetests {project}/tests
docs/options.md:CIBW_TEST_REQUIRES: nose==1.3.7 moto==0.4.31
test/test_before_test.py:        'CIBW_TEST_REQUIRES': 'nose',
test/test_before_test.py:        'CIBW_TEST_COMMAND': 'false || nosetests {project}/test',
test/test_before_test.py:        'CIBW_TEST_COMMAND_WINDOWS': 'nosetests {project}/test',
test/test_testing.py:        test = nose
test/test_testing.py:        'CIBW_TEST_REQUIRES': 'nose',
test/test_testing.py:        'CIBW_TEST_COMMAND': 'false || nosetests {project}/test',
test/test_testing.py:        'CIBW_TEST_COMMAND_WINDOWS': 'COLOR 00 || nosetests {project}/test',
test/test_testing.py:        'CIBW_TEST_COMMAND': 'false || nosetests {project}/test',
test/test_testing.py:        'CIBW_TEST_COMMAND_WINDOWS': 'COLOR 00 || nosetests {project}/test',
test/test_testing.py:            'CIBW_TEST_REQUIRES': 'nose',
test/test_testing.py:            'CIBW_TEST_COMMAND': 'nosetests {project}/test',
@henryiii henryiii changed the title [idea] Remove nose from testing [idea] Remove nose from testing & docs Dec 23, 2020
@joerick
Copy link
Contributor

joerick commented Dec 23, 2020

Yes, that makes sense to me. I think that originally it was nosetests in the testing tests rather than pytest so that we were sure that TEST_REQUIRES had worked. So it might be worth considering that when modernising. if we shell out to pytest something in our test, are we sure we aren't getting the host's version of pytest.

@henryiii
Copy link
Contributor Author

henryiii commented Dec 23, 2020

Then we could add an import X, where X is something we require? Like something pure Python near the top of this list? https://pythonwheels.com/

I'm quite sure I do this somewhere with requests. Don't remember where or why, though, just remember picking a recent version of requests.

mayeut added a commit to mayeut/cibuildwheel that referenced this issue Jun 29, 2024
mayeut added a commit to mayeut/cibuildwheel that referenced this issue Jun 29, 2024
mayeut added a commit to mayeut/cibuildwheel that referenced this issue Jun 29, 2024
@mayeut mayeut closed this as completed in 31de15b Jun 30, 2024
MusicalNinjaDad pushed a commit to MusicalNinjaDad/cibuildwheel that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants