Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'wheel' missing from setup.py install_requires list? #87

Closed
miguelsousa opened this issue Aug 21, 2018 · 2 comments
Closed

'wheel' missing from setup.py install_requires list? #87

miguelsousa opened this issue Aug 21, 2018 · 2 comments

Comments

@miguelsousa
Copy link
Contributor

While trying to use a vanilla cibuildwheel configuration with AppVeyor, I kept running into this error,

cibuildwheel: Failed to get name of the package. Command was ['c:\\python27\\python.exe', '.\\setup.py', '--name']

It was only after running that command (python .\\setup.py --name) ahead of the cibuildwheel --output-dir wheelhouse that I finally got a clue of what was going on,

setup requires that the Python package 'wheel' be installed. Try the command 'pip install wheel'.

To resolve this problem I've added 'wheel' to setup.py install_requires list in our fork.

I think that two changes are necessary:

  1. On line 111 of __main__.py, print the output of CalledProcessError, and exit with the value of returncode.
  2. Add 'wheel' to setup.py install_requires list

Do you want a PR?

@joerick
Copy link
Contributor

joerick commented Aug 21, 2018

Hey miguelsousa! Thanks for the debugging. Would love a PR for [1] above. Regarding [2], can you see where that error message is coming from? Perhaps there's something about your project's setup.py that requires it?

miguelsousa added a commit to adobe-type-tools/afdko that referenced this issue Aug 21, 2018
@miguelsousa
Copy link
Contributor Author

miguelsousa commented Aug 21, 2018

@joerick You were quite right about our setup.py; the wheel requirement came from it.
PR #88 is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants