Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change github.event.ref to github.ref #1061

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Change github.event.ref to github.ref #1061

merged 1 commit into from
Mar 29, 2022

Conversation

kjelljorner
Copy link
Contributor

According to the documentation, the variable GITHUB_REF which is accessed here via github.ref has the value refs/tags/<tag_name> for tags. github.event.ref just contains <tag_name> (as described here).

An alternative edit is of course

if: github.event_name == 'push' && startsWith(github.event.ref, 'v')

@joerick
Copy link
Contributor

joerick commented Mar 27, 2022

thanks!

@kjelljorner
Copy link
Contributor Author

No problem, keep up the good work with cibuildwheel, it helps me a lot 😄

@henryiii henryiii merged commit 63a45ab into pypa:main Mar 29, 2022
@kjelljorner kjelljorner deleted the patch-1 branch March 29, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants