Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install our dependencies outside the project directory #1488

Closed
wants to merge 2 commits into from

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 1, 2023

Testing a suggestion from #1487.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii marked this pull request as draft May 1, 2023 14:16
@henryiii
Copy link
Contributor Author

henryiii commented May 1, 2023

There are serious networking issues with GHA currently, so needs to be rebuilt later.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Contributor Author

henryiii commented May 4, 2023

@pypa/cibuildwheel-team, what do you think of this patch? This is a fix for a weird problem when you have custom build command options in setup.cfg that causes Python < 3.10 to break when running pip in the build directory - which breaks pip installs, virtual environment creation, and modern pyproject.toml based build isolation. By making sure pip is not run in the build directory, the failure no longer happens on pip install <cibuildwheel's stuff>, making it easier for the package author to work around and make it work (though all the other stuff is still broken, like adding a pyproject.toml).

I'm neutral on this - I'm not very interested in making sure cibuldwheel works when pip install, python -m venv, and adding a pyproject.toml are all broken, but this seems like a low-cost "fix" that will help make a workaround possible and will keep cibuildwheel out of the tracebacks. :)

@joerick
Copy link
Contributor

joerick commented May 7, 2023

I'm -1 on this, it adds complexity to our code without offering a functionality benefit. If we were to add it, I'd like to include a test also, but adding a test that ensures broken projects still make it through seems a bit perverse!

@henryiii henryiii closed this May 9, 2023
@henryiii henryiii deleted the henryiii/fix/installcwd branch June 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants