Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing f for fstrings in bin #659

Merged
merged 1 commit into from
May 7, 2021
Merged

fix: missing f for fstrings in bin #659

merged 1 commit into from
May 7, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 7, 2021

Recent typo.

@henryiii henryiii added the needs-backport Can/should be ported to LTS branch label May 7, 2021
@henryiii
Copy link
Contributor Author

henryiii commented May 7, 2021

#633 discovered the same bug too, it appears.

@henryiii henryiii merged commit daf850a into pypa:master May 7, 2021
@henryiii henryiii deleted the henryiii/fix/fstrings branch May 7, 2021 22:16
henryiii added a commit that referenced this pull request May 7, 2021
@henryiii
fix: missing f for fstrings in bin (#659)
fee39c2
@henryiii
Copy link
Contributor Author

henryiii commented May 7, 2021

Cherry-picked to 1.x.

@henryiii henryiii removed the needs-backport Can/should be ported to LTS branch label May 7, 2021
@mayeut
Copy link
Member

mayeut commented May 8, 2021

@henryiii,

#633 discovered the same bug too, it appears.

I thought I'd do that one on its own today but you beat me to it :-)

It was too late yesterday evening for me and that's now one item less on the to-do list, thanks.

@joerick joerick mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henryiii @mayeut