Add CPython 3.10 support #675

mayeut · 2021-05-14T14:42:48Z

Just checking if we should expect any surprise with this.
No reflection on the --pre proposal in #657 yet

henryiii · 2021-05-17T20:59:52Z

I've added a basic implementation of a --pre flag in cbef481.

henryiii · 2021-05-18T17:05:36Z

Should we un-draft this? It shouldn't build Python 3.10 wheels unless someone explicitly passes --pre.

README.md

cibuildwheel/util.py

cibuildwheel/__main__.py

mayeut · 2021-05-18T20:17:54Z

Should we un-draft this?

The dependency update script might need to be updated first, It filters out pre-releases and beta2.../rc1/... would not be picked up. I might just quote you on this:

Wouldn't this be better than updating it every time?

bin/update_pythons.py

joerick

Nice. My only comment is that I think we should keep to the convention and have an environment variable to configure this, rather than just a command line flag. I'd suggest CIBW_PRERELEASE_PYTHONS. Then we can add a little more documentation about ABI stability etc. in that option's documentation.

That then suggests the command-line option should be --prerelease-pythons. I know somebody was keen on matching pip's --pre flag, but I think our consistency is more important (CIBW_PLATFORM <-> --platform, CIBW_ARCHS <-> --archs, CIBW_OUTPUT_DIR <-> --output-dir).

README.md

henryiii · 2021-05-21T15:02:10Z

I'm not sure we should have an environment variable for this. It's a special testing flag, and not something that users should do without understanding that the wheels generated should not be uploaded to PyPI; if it's a general listed option, it might be more likely to be misused? However, having the OS variants could be useful, so I'm not against it either.

henryiii · 2021-05-21T15:02:48Z

It could be useful in a matrix to run a test, so I'm +0.1.

joerick · 2021-05-21T15:42:55Z

I'd prefer it was a sibling to CIBW_BUILD, CIBW_SKIP, CIBW_REQUIRES_PYTHON, as it's doing a very similar job to those options - build selection.

henryiii · 2021-05-21T22:24:19Z

I've added CIBW_PRERELEASE_PYTHONS.

One argument against it is that I think it's the first and only boolean option in our environment variables. It's also the only one that explicitly makes invalid-to-upload wheels. And it can be completely controlled via BUILD/SKIP if you enable it.

One argument for it is that then we'd have to add a way to use it with the GitHub action if there's no env-var (though it could just be unavailable with the action, as it's a special setting for testing only, I guess).

cibuildwheel/macos.py

docs/options.md

test/test_docker_images.py

test/test_manylinuxXXXX_only.py

joerick

Nice job. Just a few minor changes to go I think.

bin/update_pythons.py

cibuildwheel/__main__.py

cibuildwheel/macos.py

cibuildwheel/__main__.py

docs/options.md

test/test_docker_images.py

test/test_manylinuxXXXX_only.py

test/utils.py

docs/options.md

mayeut · 2021-05-24T07:06:45Z

rebased on master to get CI working.

cibuildwheel/macos.py

mayeut · 2021-05-27T10:50:05Z

I think all comments have been addressed now.
@henryiii, re-requested review from your previous approval since I included the commit from @joerick

Edit: the failure on Circle CI is unrelated to the PR and I can't re-run this one.

henryiii · 2021-05-27T20:06:11Z

cibuildwheel/__main__.py

@@ -206,6 +212,9 @@ def main() -> None:
    build_verbosity_str = get_option_from_environment(
        "CIBW_BUILD_VERBOSITY", platform=platform, default=""
    )
+    prerelease_pythons = args.prerelease_pythons or cibuildwheel.util.strtobool(
+        get_option_from_environment("CIBW_PRERELEASE_PYTHONS", platform=platform, default="0")


Grrr, this will either require it be added to the pyproject.toml (yuck, not at all a good idea for a flag like this), or removing the platform specific choices, or adding custom code back to handle platform choices but no pyproject.toml support for #684. Does it have to support platform specific variants?

I guess no platform specific variant is not an issue for this one (and shall definitely not be in pyproject.toml)

I hadn't fully considered the pyproject.toml angle, but I think you're right, it would be kinda crazy to write this into a pyproject.toml! I could imagine that perhaps this option would only be specifiable at runtime from flag or env var, if that makes you feel better henryiii? I could imagine in the docs something like-

Only configurable at runtime via --prerelease-pythons or CIBW_PRERELEASE_PYTHONS. Cannot be set in pyproject.toml.

It's interesting that CIBW_OUTPUT_DIR is another one of these runtime-only options? (maybe you've discussed this in #547, apologies, I'm behind!) Makes me wonder about a runtime-only section of the options docs, perhaps.

I'm not so worried about the platform-specific thing here, it seems pretty harmless. I wouldn't miss it either, if anyone has a stronger opinion.

Okay, I'll remove the variants for now.

CIBW_OUTPUT_DIR

This is undocumented currently, actually. It's discussed in #547, though it's a bit of an open question. I had it in the toml then I took it out, but could put it back in.

joerick

Looks great!! Nice work on this @mayeut and @henryiii !

People might want to use it, I am tempted to do a release with this... perhaps a 2.0.0a1?

Apply suggestions from code review Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>

…nux1]` test

henryiii · 2021-05-28T14:08:01Z

I'd love to get #684 into an alpha release too, so it's easier to start testing it in some projects. Though using GHA you can pin a commit, so can still test if there's no alpha for it. And I guess there could be an alpha 1 and an alpha 2, there's no cost for alphas...

mayeut force-pushed the python-3.10 branch 2 times, most recently from c9c2846 to cdfc7c3 Compare May 14, 2021 18:22

henryiii force-pushed the python-3.10 branch 3 times, most recently from 961551c to cbef481 Compare May 17, 2021 21:25

mayeut commented May 18, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

mayeut commented May 18, 2021

View reviewed changes

cibuildwheel/util.py Outdated Show resolved Hide resolved

mayeut commented May 18, 2021

View reviewed changes

cibuildwheel/__main__.py Outdated Show resolved Hide resolved

henryiii force-pushed the python-3.10 branch from 3e21f45 to d07e7ce Compare May 19, 2021 19:19

henryiii reviewed May 19, 2021

View reviewed changes

bin/update_pythons.py Outdated Show resolved Hide resolved

henryiii force-pushed the python-3.10 branch 2 times, most recently from 4d385a3 to 139e240 Compare May 19, 2021 20:52

mayeut marked this pull request as ready for review May 20, 2021 17:32

joerick reviewed May 21, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

henryiii force-pushed the python-3.10 branch from 139e240 to 0c5b04c Compare May 21, 2021 22:21

henryiii reviewed May 21, 2021

View reviewed changes

cibuildwheel/macos.py Outdated Show resolved Hide resolved

henryiii reviewed May 21, 2021

View reviewed changes

docs/options.md Outdated Show resolved Hide resolved

henryiii reviewed May 21, 2021

View reviewed changes

test/test_docker_images.py Outdated Show resolved Hide resolved

mayeut commented May 22, 2021

View reviewed changes

test/test_manylinuxXXXX_only.py Outdated Show resolved Hide resolved

joerick reviewed May 22, 2021

View reviewed changes

mayeut force-pushed the python-3.10 branch from 0c5b04c to f7ccdc1 Compare May 24, 2021 07:05

mayeut commented May 24, 2021

View reviewed changes

cibuildwheel/macos.py Show resolved Hide resolved

mayeut requested a review from henryiii May 27, 2021 10:49

henryiii reviewed May 27, 2021

View reviewed changes

henryiii approved these changes May 27, 2021

View reviewed changes

joerick approved these changes May 28, 2021

View reviewed changes

mayeut and others added 19 commits May 28, 2021 09:58

Add CPython 3.10 support

5288eba

Fix logger displaying CPython 3.1 instead of 3.10

7202539

Fix tests failing with CPython 3.10

788273e

Use pytest instead of nose

cd019ea

feat: --pre flag

3bcc1f1

Apply suggestions from code review Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>

fix: update Python update script to process beta versions

bf1f5d9

refactor: prerelease-pythons

bdde81f

Use strtobool to parse CIBW_PRERELEASE_PYTHONS env var

02f182b

Update python version filtering for universal2 & arm64

40457db

Filter out CPython 3.10 and above for `test_manylinuxXXXX_only[manyli…

1abdaac

…nux1]` test

Use CIBW_BUILD filtering rather than CIBW_SKIP for test_docker_images

87ee989

Use skip_patterns to filter out pre-releases

6cd0399

Use prerelease_pythons instead of pre

7d499ad

Reword CIBW_PRERELEASE_PYTHONS doc per review.

bfaea58

Use CIBW_PRERELEASE_PYTHONS: True for usage example.

063d168

Update cibuildwheel --help doc

64a6308

docs: add note on spec.filter

077a61e

Clean up the BuildSelector __repr__ by refactoring

9e606e0

fix: remove platform variants for CIBW_PRERELEASE_PYTHONS

daf3317

henryiii force-pushed the python-3.10 branch from 83c4ec0 to daf3317 Compare May 28, 2021 14:05

docs: mention the flag

b307f2f

henryiii merged commit 5b22fc6 into pypa:main May 28, 2021

mayeut deleted the python-3.10 branch May 29, 2021 08:31

mayeut mentioned this pull request May 24, 2022

feature: add CPython 3.11 support #1109

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CPython 3.10 support #675

Add CPython 3.10 support #675

mayeut commented May 14, 2021 •

edited

Loading

henryiii commented May 17, 2021 •

edited

Loading

henryiii commented May 18, 2021

mayeut commented May 18, 2021

joerick left a comment

henryiii commented May 21, 2021

henryiii commented May 21, 2021

joerick commented May 21, 2021

henryiii commented May 21, 2021

joerick left a comment

mayeut commented May 24, 2021

mayeut commented May 27, 2021 •

edited

Loading

henryiii May 27, 2021

mayeut May 27, 2021

joerick May 28, 2021 •

edited

Loading

henryiii May 28, 2021

joerick left a comment

henryiii commented May 28, 2021

Add CPython 3.10 support #675

Add CPython 3.10 support #675

Conversation

mayeut commented May 14, 2021 • edited Loading

henryiii commented May 17, 2021 • edited Loading

henryiii commented May 18, 2021

mayeut commented May 18, 2021

joerick left a comment

Choose a reason for hiding this comment

henryiii commented May 21, 2021

henryiii commented May 21, 2021

joerick commented May 21, 2021

henryiii commented May 21, 2021

joerick left a comment

Choose a reason for hiding this comment

mayeut commented May 24, 2021

mayeut commented May 27, 2021 • edited Loading

henryiii May 27, 2021

Choose a reason for hiding this comment

mayeut May 27, 2021

Choose a reason for hiding this comment

joerick May 28, 2021 • edited Loading

Choose a reason for hiding this comment

henryiii May 28, 2021

Choose a reason for hiding this comment

joerick left a comment

Choose a reason for hiding this comment

henryiii commented May 28, 2021

mayeut commented May 14, 2021 •

edited

Loading

henryiii commented May 17, 2021 •

edited

Loading

mayeut commented May 27, 2021 •

edited

Loading

joerick May 28, 2021 •

edited

Loading