-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .pypirc specification #734
Conversation
LGTM from user's perspective. Also clears up how the "don't save your token in plaintext" wizardry works |
To see the rendered version without building locally, check out: https://bhrutledge-ppug.bhrutledge.now.sh/specifications/pypirc.html |
@di I hope you'll forgive the nudge, but I'd appreciate your thoughts on this before I link to it from other parts of the guide. And, ultimately, it'd be nice to resolve pypa/twine#638. |
@bhrutledge On my list for today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, only one suggestion & a reiteration of a previous comment.
For reference, here is the distutils documentation about .pypirc before it was deleted from the CPython repo: https://github.com/python/cpython/blob/v3.4.10/Doc/distutils/packageindex.rst#the-pypirc-file |
Thanks! I actually started with that, then updated/expanded it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Any other @pypa/packaging-user-guide-editors want to review? |
Closes #730.
I'm starting this out as a draft PR, because I think a complete PR would include updates to other documents that reference
.pypirc
. However, before spending time on that, I'd like get the content of this document approved.