Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pypirc specification #734

Merged
merged 4 commits into from
Jun 5, 2020
Merged

Add .pypirc specification #734

merged 4 commits into from
Jun 5, 2020

Conversation

bhrutledge
Copy link
Contributor

Closes #730.

I'm starting this out as a draft PR, because I think a complete PR would include updates to other documents that reference .pypirc. However, before spending time on that, I'd like get the content of this document approved.

@stdedos
Copy link

stdedos commented May 30, 2020

LGTM from user's perspective.

Also clears up how the "don't save your token in plaintext" wizardry works

@bhrutledge
Copy link
Contributor Author

To see the rendered version without building locally, check out:

https://bhrutledge-ppug.bhrutledge.now.sh/specifications/pypirc.html

@stdedos
Copy link

stdedos commented May 30, 2020

Thank you for the extra mile!

Also in-line rendering looks good enough to get rendered text display
image

@bhrutledge
Copy link
Contributor Author

bhrutledge commented Jun 2, 2020

@di I hope you'll forgive the nudge, but I'd appreciate your thoughts on this before I link to it from other parts of the guide. And, ultimately, it'd be nice to resolve pypa/twine#638.

@di
Copy link
Sponsor Member

di commented Jun 2, 2020

@bhrutledge On my list for today.

source/specifications/pypirc.rst Show resolved Hide resolved
source/specifications/pypirc.rst Outdated Show resolved Hide resolved
source/specifications/pypirc.rst Outdated Show resolved Hide resolved
source/specifications/pypirc.rst Outdated Show resolved Hide resolved
source/specifications/pypirc.rst Outdated Show resolved Hide resolved
source/specifications/pypirc.rst Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, only one suggestion & a reiteration of a previous comment.

source/specifications/pypirc.rst Outdated Show resolved Hide resolved
source/specifications/pypirc.rst Outdated Show resolved Hide resolved
@merwok
Copy link
Contributor

merwok commented Jun 4, 2020

For reference, here is the distutils documentation about .pypirc before it was deleted from the CPython repo: https://github.com/python/cpython/blob/v3.4.10/Doc/distutils/packageindex.rst#the-pypirc-file

@bhrutledge
Copy link
Contributor Author

For reference, here is the distutils documentation about .pypirc before it was deleted from the CPython repo

Thanks! I actually started with that, then updated/expanded it.

@bhrutledge bhrutledge requested a review from di June 5, 2020 10:25
Copy link
Sponsor Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@di
Copy link
Sponsor Member

di commented Jun 5, 2020

Any other @pypa/packaging-user-guide-editors want to review?

@theacodes theacodes merged commit 86c0641 into pypa:master Jun 5, 2020
@bhrutledge bhrutledge deleted the 730-pypirc branch June 8, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documention for .pypirc format
5 participants