Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #998

Closed
wants to merge 3 commits into from
Closed

Fix broken links #998

wants to merge 3 commits into from

Conversation

bhrutledge
Copy link
Contributor

Discovered while looking at some open PR's, and currently failing on main:

https://github.com/pypa/packaging.python.org/runs/3850844441?check_suite_focus=true

`Docs <https://packaging.python.org/en/latest/>`__ |
`Docs <https://packaging.python.org/>`__ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is surprising to me. Should https://packaging.python.org/en/latest/ work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the locale prefix has been disabled at some point. I'm also not sure if we need to build all of the languages under the same RTD project because they may have different amounts of translation, potentially emitting warnings/errors when the English version changes but all of the translations aren't yet caught up with the new version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I thought it's been fixed in one of the other PRs. Let me see if it got merged...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used intersphinx for this in #975:

:doc:`Docs <packaging.python.org:index>`

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging #975, check for conflicts afterwards.

@@ -733,4 +733,4 @@ Examples::
.. _`Python Package Index`: http://pypi.org/

.. [2] RFC 822 Long Header Fields:
http://www.freesoft.org/CIE/RFC/822/7.htm
https://datatracker.ietf.org/doc/html/rfc822#section-3.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RFCs, just use the :rfc: role in the source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unnecessary anymore. Fixed in #975.

`Docs <https://packaging.python.org/en/latest/>`__ |
`Docs <https://packaging.python.org/>`__ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I thought it's been fixed in one of the other PRs. Let me see if it got merged...

@bhrutledge
Copy link
Contributor Author

I forgot about #975. Looks like this wasn't necessary. 🤦

@bhrutledge bhrutledge closed this Oct 10, 2021
@webknjaz
Copy link
Member

Sorry I didn't merge that one sooner, it was updated while I was on vacation and I forgot about it for a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants