Skip to content

Commit

Permalink
Use isort (#377)
Browse files Browse the repository at this point in the history
Simplifies refactoring work by letting the tools handle import
formatting.
  • Loading branch information
jdufresne committed Jan 4, 2021
1 parent 353f270 commit 28d2fa0
Show file tree
Hide file tree
Showing 14 changed files with 51 additions and 30 deletions.
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
Expand Up @@ -23,6 +23,11 @@ repos:
hooks:
- id: black

- repo: https://github.com/PyCQA/isort
rev: 5.6.4
hooks:
- id: isort

- repo: https://gitlab.com/PyCQA/flake8
rev: "3.7.8"
hooks:
Expand Down
16 changes: 8 additions & 8 deletions noxfile.py
@@ -1,17 +1,17 @@
# mypy: disallow-untyped-defs=False, disallow-untyped-calls=False

import time
import re
import os
import sys
import contextlib
import datetime
import difflib
import glob
import os
import re
import shutil
import difflib
import subprocess
import sys
import tempfile
import textwrap
import datetime
import contextlib
import subprocess
import time
from pathlib import Path

import nox
Expand Down
16 changes: 12 additions & 4 deletions packaging/markers.py
Expand Up @@ -8,13 +8,21 @@
import platform
import sys

from pyparsing import ParseException, ParseResults, stringStart, stringEnd
from pyparsing import ZeroOrMore, Group, Forward, QuotedString
from pyparsing import Literal as L # noqa
from pyparsing import ( # noqa: N817
Forward,
Group,
Literal as L,
ParseException,
ParseResults,
QuotedString,
ZeroOrMore,
stringEnd,
stringStart,
)

from ._compat import string_types
from ._typing import TYPE_CHECKING
from .specifiers import Specifier, InvalidSpecifier
from .specifiers import InvalidSpecifier, Specifier

if TYPE_CHECKING: # pragma: no cover
from typing import Any, Callable, Dict, List, Optional, Tuple, Union
Expand Down
17 changes: 13 additions & 4 deletions packaging/requirements.py
Expand Up @@ -3,13 +3,22 @@
# for complete details.
from __future__ import absolute_import, division, print_function

import string
import re
import string
import sys

from pyparsing import stringStart, stringEnd, originalTextFor, ParseException
from pyparsing import ZeroOrMore, Word, Optional, Regex, Combine
from pyparsing import Literal as L # noqa
from pyparsing import ( # noqa: N817
Combine,
Literal as L,
Optional,
ParseException,
Regex,
Word,
ZeroOrMore,
originalTextFor,
stringEnd,
stringStart,
)

from ._typing import TYPE_CHECKING
from .markers import MARKER_EXPR, Marker
Expand Down
4 changes: 2 additions & 2 deletions packaging/specifiers.py
Expand Up @@ -12,10 +12,10 @@
from ._compat import string_types, with_metaclass
from ._typing import TYPE_CHECKING
from .utils import canonicalize_version
from .version import Version, LegacyVersion, parse
from .version import LegacyVersion, Version, parse

if TYPE_CHECKING: # pragma: no cover
from typing import List, Dict, Union, Iterable, Iterator, Optional, Callable, Tuple
from typing import Callable, Dict, Iterable, Iterator, List, Optional, Tuple, Union

ParsedVersion = Union[Version, LegacyVersion]
UnparsedVersion = Union[Version, LegacyVersion, str]
Expand Down
2 changes: 1 addition & 1 deletion packaging/tags.py
Expand Up @@ -27,9 +27,9 @@

if TYPE_CHECKING: # pragma: no cover
from typing import (
IO,
Dict,
FrozenSet,
IO,
Iterable,
Iterator,
List,
Expand Down
4 changes: 4 additions & 0 deletions setup.cfg
@@ -1,2 +1,6 @@
[bdist_wheel]
universal=1

[isort]
profile = black
combine_as_imports = true
2 changes: 1 addition & 1 deletion tasks/check.py
Expand Up @@ -2,8 +2,8 @@
# 2.0, and the BSD License. See the LICENSE file in the root of this repository
# for complete details.

import json
import itertools
import json
import os.path

try:
Expand Down
1 change: 0 additions & 1 deletion tasks/paths.py
Expand Up @@ -4,7 +4,6 @@

import os.path


PROJECT = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))

CACHE = os.path.join(PROJECT, ".cache")
5 changes: 2 additions & 3 deletions tests/test_markers.py
Expand Up @@ -13,16 +13,15 @@
import pytest

from packaging.markers import (
Node,
InvalidMarker,
Marker,
Node,
UndefinedComparison,
UndefinedEnvironmentName,
Marker,
default_environment,
format_full_version,
)


VARIABLES = [
"extra",
"implementation_name",
Expand Down
3 changes: 1 addition & 2 deletions tests/test_requirements.py
Expand Up @@ -6,8 +6,7 @@
import pytest

from packaging.markers import Marker
from packaging.requirements import InvalidRequirement, Requirement, URL
from packaging.requirements import URL_AND_MARKER
from packaging.requirements import URL, URL_AND_MARKER, InvalidRequirement, Requirement
from packaging.specifiers import SpecifierSet


Expand Down
3 changes: 1 addition & 2 deletions tests/test_specifiers.py
Expand Up @@ -17,8 +17,7 @@
)
from packaging.version import LegacyVersion, Version, parse

from .test_version import VERSIONS, LEGACY_VERSIONS

from .test_version import LEGACY_VERSIONS, VERSIONS

LEGACY_SPECIFIERS = [
"==2.1.0.3",
Expand Down
1 change: 0 additions & 1 deletion tests/test_tags.py
Expand Up @@ -12,7 +12,6 @@
except ImportError:
ctypes = None
import distutils.util

import os
import platform
import re
Expand Down
2 changes: 1 addition & 1 deletion tests/test_version.py
Expand Up @@ -10,7 +10,7 @@
import pretend
import pytest

from packaging.version import Version, LegacyVersion, InvalidVersion, parse
from packaging.version import InvalidVersion, LegacyVersion, Version, parse


@pytest.mark.parametrize(
Expand Down

0 comments on commit 28d2fa0

Please sign in to comment.