Skip to content

Commit

Permalink
Merge pull request #10566 from n1000/dont_warn_on_bsd
Browse files Browse the repository at this point in the history
  • Loading branch information
uranusjr authored and pradyunsg committed Oct 22, 2021
1 parent abec8a7 commit 0c2574b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions news/10565.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Tweak running-as-root detection, to check ``os.getuid`` if it exists, on Unix-y and non-Linux/non-MacOS machines.
7 changes: 4 additions & 3 deletions src/pip/_internal/cli/req_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,10 @@ def warn_if_run_as_root() -> None:
# checks: https://mypy.readthedocs.io/en/stable/common_issues.html
if sys.platform == "win32" or sys.platform == "cygwin":
return
if sys.platform == "darwin" or sys.platform == "linux":
if os.getuid() != 0:
return

if os.getuid() != 0:
return

logger.warning(
"Running pip as the 'root' user can result in broken permissions and "
"conflicting behaviour with the system package manager. "
Expand Down

0 comments on commit 0c2574b

Please sign in to comment.