Merge pull request #4711 from pradyunsg/refactor/req-set-reduction-1

Get rid of successfully_installed attr
pypa · Sep 7, 2017 · 4b5a0d5 · 4b5a0d5
2 parents 28cca11 + 1240a81
commit 4b5a0d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/pip/_internal/commands/install.py b/src/pip/_internal/commands/install.py
@@ -291,7 +291,7 @@ def run(self, options, args):
                         # installed from the sdist/vcs whatever.
                         wb.build(session=session, autobuilding=True)
 
-                    requirement_set.install(
+                    installed = requirement_set.install(
                         install_options,
                         global_options,
                         root=options.root_path,
@@ -305,9 +305,7 @@ def run(self, options, args):
                         prefix=options.prefix_path,
                         isolated=options.isolated_mode,
                     )
-                    reqs = sorted(
-                        requirement_set.successfully_installed,
-                        key=operator.attrgetter('name'))
+                    reqs = sorted(installed, key=operator.attrgetter('name'))
                     items = []
                     for req in reqs:
                         item = req.name

diff --git a/src/pip/_internal/req/req_set.py b/src/pip/_internal/req/req_set.py
@@ -28,7 +28,6 @@ def __init__(self,
         self.requirement_aliases = {}
         self.unnamed_requirements = []
         self.successfully_downloaded = []
-        self.successfully_installed = []
         self.reqs_to_cleanup = []
         self.use_user_site = use_user_site
         self.target_dir = target_dir  # set from --target option
@@ -243,4 +242,4 @@ def install(self, install_options, global_options=(), *args, **kwargs):
                         requirement.uninstalled_pathset.commit()
                 requirement.remove_temporary_source()
 
-        self.successfully_installed = to_install
+        return to_install