Skip to content

Commit

Permalink
Merge pull request #4989 from pradyunsg/misc/better-pep-518-message
Browse files Browse the repository at this point in the history
Improve message when setuptools is missing (PEP 518)
  • Loading branch information
pfmoore committed Mar 26, 2018
2 parents d6e050a + 398fea8 commit 61eda75
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions src/pip/_internal/operations/prepare.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,13 @@ def prep_for_dist(self, finder, build_isolation):

if 'setuptools' not in build_requirements:
logger.warning(
"This version of pip does not implement PEP 516, so "
"it cannot build a wheel without setuptools. You may need to "
"upgrade to a newer version of pip.")
"%s does not include 'setuptools' as a buildtime requirement "
"in its pyproject.toml.", self.req.name,
)
logger.warning(
"This version of pip does not implement PEP 517 so it cannot "
"build a wheel without setuptools."
)

if not should_isolate:
self.req.build_env = NoOpBuildEnvironment(no_clean=False)
Expand Down

0 comments on commit 61eda75

Please sign in to comment.