Merge pull request #5659 from patter001/master

fix for: Incorrect username/password gives misleading error
pypa · Oct 16, 2018 · 7f3b2c1 · 7f3b2c1
2 parents 83b879b + e3c869f
commit 7f3b2c1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/news/4833.bugfix b/news/4833.bugfix
@@ -0,0 +1 @@
+give 401 warning if username/password do not work for URL
diff --git a/src/pip/_internal/download.py b/src/pip/_internal/download.py
@@ -199,13 +199,20 @@ def handle_401(self, resp, **kwargs):
 
         # Add our new username and password to the request
         req = HTTPBasicAuth(username or "", password or "")(resp.request)
+        req.register_hook("response", self.warn_on_401)
 
         # Send our new request
         new_resp = resp.connection.send(req, **kwargs)
         new_resp.history.append(resp)
 
         return new_resp
 
+    def warn_on_401(self, resp, **kwargs):
+        # warn user that they provided incorrect credentials
+        if resp.status_code == 401:
+            logger.warning('401 Error, Credentials not correct for %s',
+                           resp.request.url)
+
     def parse_credentials(self, netloc):
         if "@" in netloc:
             userinfo = netloc.rsplit("@", 1)[0]