Merge pull request #5799 from cjerdonek/simplify-get-src-requirement

Remove two unreachable returns in VersionControl.get_src_requirement()
pypa · Sep 24, 2018 · 9408cd9 · 9408cd9
2 parents a1b326d + 59b8a80
commit 9408cd9
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 4 deletions.
diff --git a/news/8CC94B14-B963-4645-BB9C-D63C6D854294.trivial b/news/8CC94B14-B963-4645-BB9C-D63C6D854294.trivial
diff --git a/src/pip/_internal/vcs/git.py b/src/pip/_internal/vcs/git.py
@@ -295,8 +295,6 @@ def get_src_requirement(self, dist, location):
         if not repo.lower().startswith('git:'):
             repo = 'git+' + repo
         egg_project_name = dist.egg_name().split('-', 1)[0]
-        if not repo:
-            return None
         current_rev = self.get_revision(location)
         req = '%s@%s#egg=%s' % (repo, current_rev, egg_project_name)
         subdirectory = self._get_subdirectory(location)

diff --git a/src/pip/_internal/vcs/mercurial.py b/src/pip/_internal/vcs/mercurial.py
@@ -89,8 +89,6 @@ def get_src_requirement(self, dist, location):
         if not repo.lower().startswith('hg:'):
             repo = 'hg+' + repo
         egg_project_name = dist.egg_name().split('-', 1)[0]
-        if not repo:
-            return None
         current_rev_hash = self.get_revision_hash(location)
         return '%s@%s#egg=%s' % (repo, current_rev_hash, egg_project_name)