Merge pull request #9156 from jdufresne/resource-warning

Always close stderr after subprocess completion in call_subprocess()
pypa · Nov 21, 2020 · a19f130 · a19f130
2 parents 396afb1 + 8662248
commit a19f130
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/news/9156.bugfix.rst b/news/9156.bugfix.rst
@@ -0,0 +1 @@
+Fix ResourceWarning in VCS subprocesses
diff --git a/src/pip/_internal/vcs/versioncontrol.py b/src/pip/_internal/vcs/versioncontrol.py
@@ -150,6 +150,8 @@ def call_subprocess(
     finally:
         if proc.stdout:
             proc.stdout.close()
+        if proc.stderr:
+            proc.stderr.close()
 
     proc_had_error = (
         proc.returncode and proc.returncode not in extra_ok_returncodes