New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 bugs when downloading wheels #1112

Closed
qwcode opened this Issue Aug 6, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@qwcode
Contributor

qwcode commented Aug 6, 2013

2 problems:

  1. downloading directly from wheel paths or urls produces an exception due to the requirement not having a "name"
Exception:
Traceback (most recent call last):
  File "/home/qwcode/p/pip/pip/basecommand.py", line 129, in main
    status = self.run(options, args)
  File "/home/qwcode/p/pip/pip/commands/install.py", line 333, in run
    req.name for req in requirement_set.successfully_downloaded
TypeError: sequence item 0: expected string, NoneType found
  1. the logic for downloading wheels is flawed in that dependencies of wheels won't be downloaded. the wheel dependency processing logic is in the wrong place.
@dholth

This comment has been minimized.

Show comment
Hide comment
@dholth

dholth Aug 27, 2013

Member

I thought about editing run_egg_info() to just detect that it's in a wheel and perform a noop... since the info is already there.

Member

dholth commented Aug 27, 2013

I thought about editing run_egg_info() to just detect that it's in a wheel and perform a noop... since the info is already there.

qwcode added a commit to qwcode/pip that referenced this issue Feb 2, 2014

qwcode added a commit that referenced this issue Feb 2, 2014

Merge pull request #1527 from qwcode/wheel_deps
fixes for downloading wheels (Issue #1112)
@qwcode

This comment has been minimized.

Show comment
Hide comment
@qwcode

qwcode Feb 2, 2014

Contributor

closing due to merge of #1527

Contributor

qwcode commented Feb 2, 2014

closing due to merge of #1527

@qwcode qwcode closed this Feb 2, 2014

qwcode added a commit to qwcode/pip that referenced this issue Feb 8, 2014

fixes for downloading wheels (Issue pypa#1112)
Conflicts:
	pip/req/req_set.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment