Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 bugs when downloading wheels #1112

Closed
qwcode opened this issue Aug 6, 2013 · 2 comments
Closed

2 bugs when downloading wheels #1112

qwcode opened this issue Aug 6, 2013 · 2 comments
Labels
auto-locked Outdated issues that have been locked by automation C: download About fetching data from PyPI and other sources C: unnamed reqs Handling and processing unnamed requirements C: wheel The wheel format and 'pip wheel' command type: bug A confirmed bug or unintended behavior

Comments

@qwcode
Copy link
Contributor

qwcode commented Aug 6, 2013

2 problems:

  1. downloading directly from wheel paths or urls produces an exception due to the requirement not having a "name"
Exception:
Traceback (most recent call last):
  File "/home/qwcode/p/pip/pip/basecommand.py", line 129, in main
    status = self.run(options, args)
  File "/home/qwcode/p/pip/pip/commands/install.py", line 333, in run
    req.name for req in requirement_set.successfully_downloaded
TypeError: sequence item 0: expected string, NoneType found
  1. the logic for downloading wheels is flawed in that dependencies of wheels won't be downloaded. the wheel dependency processing logic is in the wrong place.
@dholth
Copy link
Member

dholth commented Aug 27, 2013

I thought about editing run_egg_info() to just detect that it's in a wheel and perform a noop... since the info is already there.

qwcode added a commit that referenced this issue Feb 2, 2014
fixes for downloading wheels (Issue #1112)
@qwcode
Copy link
Contributor Author

qwcode commented Feb 2, 2014

closing due to merge of #1527

@qwcode qwcode closed this as completed Feb 2, 2014
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: download About fetching data from PyPI and other sources C: unnamed reqs Handling and processing unnamed requirements C: wheel The wheel format and 'pip wheel' command type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants