open_logfile fails if filename has no directory

[vbabiy]

http://bitbucket.org/ianb/pip/changeset/1719fb9024eb introduced behavior to create the log directory if it does not already exist. This fails, however, if the logfile is just a filename with no dirname.

In this case, dirname is an empty string, and os.path.exists('') is always False. os.makedirs('') fails with

OSError: [Errno 2] No such file or directory: ''

Changing line 188 to:

if dirname and not os.path.exists(dirname):

should resolve the issue.

I encountered this issue when using pip via gp.recipe.pip.

---

• Bitbucket: https://bitbucket.org/ianb/pip/issue/90
• Originally Reported By: Nathan Yergler
• Originally Created At: 2010-04-19 05:10:30

[vbabiy]

This should fix the issue. Please pull that changeset.

http://bitbucket.org/aconrad/pip/changeset/9a62890050bf

Thanks for reporting.

---

Original Comment By: Alexandre Conrad

[vbabiy]

fix logfile with no dirname; fixes #90

→ [Author: Carl Meyer

Age: 11 months ago

fix logfile with no dirname; fixes 90">r521:55a8f6a4ba1f]2

no

---

Original Comment By: Carl Meyer

[vbabiy]

Resolve dirname given a log filename like 'foo.log'. Fixes #90.

→ [Author: aconrad

Age: 11 months ago

Resolve dirname given a log filename like 'foo.log'. Fixes
90.">r530:9a62890050bf]2

no

---

Original Comment By: Ian Bicking