Terminal control codes being output even with "-q" (as of 8.0.0)

[tianon]

I think examples of output will illustrate the bug far more clearly than I can describe:

$ pip --version
pip 8.0.2 from /usr/local/lib/python3.5/site-packages (python 3.5)
$ pip install -q sh | hexdump -C
00000000  1b 5b 3f 32 35 6c 1b 5b  3f 32 35 68              |.[?25l.[?25h|
0000000c
$ 

Compare to previous (expected) output:

$  pip --version
pip 7.1.2 from /usr/local/lib/python3.5/site-packages (python 3.5)
$ pip install -q sh | hexdump -C
$ 

It's probably also worth noting that piping the output didn't suppress these either (as might also be expected). 👍

(Happy to provide more detail or do more debugging as desired!)

[mattrobenolt]

To add to this, I can't reproduce on OSX. It seems to only be on Linux.

[mattrobenolt]

Going to assume it's all in here: https://github.com/pypa/pip/blob/master/pip/_vendor/progress/helpers.py :)

[xavfernandez]

Bisecting lead to 5bb9899 certainly the contextmanager hidden_cursor that always write the control characters.

cc @njsmith if you have any idea :)

[njsmith]

Doh, yes, definitely my fault. Ugh. The interaction between the use of the logging system for output + the desire for fancy terminal display is very nasty and error prone...

I guess hidden_cursor's output should be protected by the incantation

if file.isatty() and logger.getEffectiveLevel() <= logging.INFO: ...

I can make a patch containing the above but I don't know how to write a test for it, so I'd appreciate tips on that. Or given how trivial the fix itself is maybe it'd be quicker just to do it yourself, either way :-)

[frewsxcv]

Is there anything I can do to help with this? This is preventing everyone (including myself) from using pip 8.x with the Python docker image

[njsmith]

Submitted a PR.