Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 518 support ignore extras in build requirements #5265

Closed
benoit-pierre opened this issue Apr 17, 2018 · 1 comment · Fixed by #5286
Closed

PEP 518 support ignore extras in build requirements #5265

benoit-pierre opened this issue Apr 17, 2018 · 1 comment · Fixed by #5286
Labels
auto-locked Outdated issues that have been locked by automation type: bug A confirmed bug or unintended behavior

Comments

@benoit-pierre
Copy link
Member

benoit-pierre commented Apr 17, 2018

  • Pip version: 10
  • Python version: 3.6
  • Operating system: Arch Linux

Description:

For the same underlying reasons as #5230, extras in build requirements are simply ignored.

Steps to reproduce:

> rm -rf sample_project
> mkdir sample_project
> printf 'import setuptools; setuptools.setup(name="sample_project", version="0.1")\n' >sample_project/setup.py
> printf '[build-system]\nrequires = ["wheel", "setuptools", "requires_simple_extra[extra]"]\n' >sample_project/pyproject.toml
> rm -rf tmp && PYTHONPATH=$PWD/src python -m pip install -t tmp -f tests/data/packages/ ./sample_project
Looking in links: tests/data/packages/
Processing ./sample_project
  Installing build dependencies ... done
Building wheels for collected packages: sample-project
  Running setup.py bdist_wheel for sample-project ... done
  Stored in directory: /tmp/pip-ephem-wheel-cache-y9t4gjis/wheels/f1/39/94/a966d73011f6634dd4d5546764ef9d85816b44b36f176032a5
Successfully built sample-project
Installing collected packages: sample-project
Successfully installed sample-project-0.1

The last command should fail because tests/data/packages does not contain a wheel for simple==1.0.

@pradyunsg pradyunsg added the type: bug A confirmed bug or unintended behavior label May 10, 2018
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants