Make link logging more consistent

[xavfernandez]

What's the problem this feature will solve?

Links are sometimes logged via their __str__ method (cf

pip/src/pip/_internal/operations/prepare.py

Line 480 in 81f0572

"HTTP error %s while getting %s", exc.response.status_code, link,

), sometimes with custom logic like in

pip/src/pip/_internal/operations/prepare.py

Lines 135 to 140 in 81f0572

	if link.netloc == PyPI.file_storage_domain:
	url = link.show_url
	else:
	url = link.url_without_fragment
	redacted_url = redact_auth_from_url(url)

And on top of that we have a special case for PyPI downloads.

Like Chris pointed out in #7384 (comment) this special case (reintroduced via #7225) doesn't help with debugging.

Describe the solution you'd like

Always use the same logic (a Link property (or __str__) when logging a link, ideally with identical logic when dealing wih filepath or VCS urls.

This could involve always using link.show_url for info logs and provide the full (redacted) url in --verbose mode.

Alternative Solutions

Statu quo.

[pradyunsg]

I'd say we can drop the discussion needed and relabel this as awaiting PR.

[andyalbert]

Hello, I tried to pick up this issue, but this code snippet is not there anymore on the main branch, I think we can close this issue.

[uranusjr]

There is still custom logic in e.g. network/download.py. You might find more by searching redact_auth_from_url through the code base and identify usages like this:

url = link.url  # Or e.g. url_without_fragment
redact_auth_from_url(url)