Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show shorter details of the URL when downloading from PyPI

Merged
merged 3 commits into from Oct 17, 2019

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Oct 16, 2019

This was something I noticed while working w/ folks at PyCon India.

We had, in the past, shown shorter link names in our output, when downloading from PyPI. This PR restores that ability as well as updating a test so that we don't accidentally start printing it again.

ref: 383de6d

@pypa-bot
Copy link

pypa-bot commented Oct 16, 2019

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@pypa-bot pypa-bot added the needs rebase or merge label Oct 16, 2019
@pradyunsg
Copy link
Member Author

pradyunsg commented Oct 16, 2019

Ahahah

@pypa-bot pypa-bot removed the needs rebase or merge label Oct 16, 2019
@pradyunsg pradyunsg merged commit 8c50c8a into pypa:master Oct 17, 2019
24 checks passed
@lock lock bot added the auto-locked label Nov 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
@pradyunsg pradyunsg deleted the show-better-urls branch Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants