Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from retrying to tenacity #7530

Closed
pradyunsg opened this issue Dec 31, 2019 · 1 comment · Fixed by #9599
Closed

Switch from retrying to tenacity #7530

pradyunsg opened this issue Dec 31, 2019 · 1 comment · Fixed by #9599
Labels
project: vendored dependency Related to a vendored dependency type: refactor Refactoring code

Comments

@pradyunsg
Copy link
Member

Looks like retrying is no longer maintained: rholder/retrying#79

We can switch to using https://github.com/jd/tenacity instead, which is "mostly" API compatible, and seems to be in a better state -- maintenance wise.

Originally posted by @chrahunt in #7363 (comment)
@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Dec 31, 2019
@pradyunsg pradyunsg added project: vendored dependency Related to a vendored dependency type: refactor Refactoring code labels Dec 31, 2019
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Dec 31, 2019
@yeraydiazdiaz yeraydiazdiaz mentioned this issue Jan 13, 2020
Closed
@yeraydiazdiaz
Copy link

For visibility, I had a go at this issue in #7592 but found there was some complexity due to tenacity depending on futures for Python 2.7.

@cjc7373 cjc7373 mentioned this issue Feb 11, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
project: vendored dependency Related to a vendored dependency type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
2 participants
@pradyunsg @yeraydiazdiaz