-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResolutionTooDeep error message #8380
Comments
Due to parameter changes, the priority coming up with a ResolutionTooDeep error message has been reduced. I'm going to keep this on the back-burner and will get back to it. |
I'm thinking something like this might work:
Would be nice here to link to the resolver error message template, but the URL is very long: @ei8fdb suggested that we might be able to use GitHub's URL shortener, but we'd want to check that users trust it. fyi @uranusjr |
The message looks good to me in general, except “timed out” could potentially be misleading since it sounds like a networking term to me. Maybe change it to something more vague like pip has spent too long while…? It seems that this URL also points to the error message template. Would it be short enough? Or maybe we can set up some kind of URL shortener service for this. https://github.com/pypa/pip/issues/new?template=resolver-failure.md |
One point I'd flag is "Timed out" and "Too long" seems to imply time is the factor for determining when to stop, whereas I think we should say something like "tried too many package versions" instead. |
🤔 A few options:
I think the last one is probably most accurate. what do you think? |
All of the options sound good to me. |
@ei8fdb do you have a preference here? |
First and last work well for me. OK with the third. :) |
Taking an executive decision here. If there are no strong objections, we will go with a more concise edit of version 4:
Next steps:
|
I'll do some research on this. I hope to get initial answers by end of week (26th June). |
Per a meeting earlier this month, we've now improved the error message and the current behavior is acceptable for the pip 20.3 release. There's still room for improvement, so I'm leaving the issue open, but I've removed it from the list of blockers for pip 20.3. |
Closing this out, since we don't see any more user reports of people hitting this. I think we've made significant improvements to the resolver since we had this, and this is no longer a concern. If we see users hitting this in the future, I think it'd be useful to look at this again with the details of the situation from an actual user hitting this. |
Work-in-progress.
What's the problem this feature will solve?
Describe the solution you'd like
First solution will be:
Alternative Solutions
Additional context
Real life cases of ResolutionTooDeep - #8204, #8316, #8314, #8290,
The text was updated successfully, but these errors were encountered: