Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reporting candidate location, handle cached wheels better #8463

Open
pfmoore opened this issue Jun 18, 2020 · 3 comments
Open

When reporting candidate location, handle cached wheels better #8463

pfmoore opened this issue Jun 18, 2020 · 3 comments
Labels
C: dependency resolution About choosing which dependencies to install C: error messages Improving error messages

Comments

@pfmoore
Copy link
Member

pfmoore commented Jun 18, 2020

Can we use the original link w/ (cached) in the name in that case?

OK to do this in a follow up, if you file an issue to aggregate all the call sites that print req.link.

Originally posted by @pradyunsg in #8394

@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Jun 18, 2020
@brainwane brainwane added C: new resolver C: error messages Improving error messages and removed S: needs triage Issues/PRs that need to be triaged labels Jul 30, 2020
@pradyunsg
Copy link
Member

For context, this is the relevant comment: #8394 (comment)

@brainwane
Copy link
Contributor

I just spoke with Pradyun.

Currently, when a user gets a Resolution Conflict error or similar, if pip grabbed one of the packages from local cache, the output that the user sees is very very lengthy, which does not feel polished. It would make more sense to print the name of the package and then the string " (cached)" or something like that, as in:

python-social-auth (cached)

This seems like a polish issue rather than a problem that needs solving before the 20.3 release in October.

I'm not sure how "call sites that print req.link" are related to this but I presume that they are because of #8394 (comment) .

@uranusjr
Copy link
Member

uranusjr commented Mar 7, 2021

Note for future contributors: Some logic in #7898 would be useful for this.

@pradyunsg pradyunsg added C: dependency resolution About choosing which dependencies to install and removed C: new resolver labels Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: dependency resolution About choosing which dependencies to install C: error messages Improving error messages
Projects
None yet
Development

No branches or pull requests

4 participants