Complete type annotations in pip/_internal/commands
#10182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jul 23, 2021
| @@ -18,7 +18,7 @@ | |||
| # in a test-related module). | |||
| # Finally, we need to pass an iterable of pairs here rather than a dict | |||
| # so that the ordering won't be lost when using Python 2.7. | |||
| commands_dict = OrderedDict([ | |||
| commands_dict: "OrderedDict[str, CommandInfo]" = OrderedDict([ | |||
There was a problem hiding this comment.
You need to jump through some hoops for this to work on 3.6.
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from typing import OrderedDict
else:
from collections import OrderedDict
commands_dict: "OrderedDict[str, CommandInfo]" = OrderedDict(...)But does this have to be an ordered dict? Usually it's good enough to just annotate this as dict.
There was a problem hiding this comment.
But does this have to be an ordered dict? Usually it's good enough to just annotate this as dict.
Agree, I'll change OrderedDict to Dict.
There was a problem hiding this comment.
FWIW, given that we're Python 3.6+, we can also just change this into a dictionary; since those are ordered starting Python 3.6.
But that can be done separately.
There was a problem hiding this comment.
Sounds good, thanks for the suggestion!
uranusjr
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete type annotations in
pip/_internal/commands.